Some other options:

• default the content_type in https://github.com/rails/rails/blob/master/activestorage/lib/active_storage/service/disk_service.rb
• solve specifically for xls and only change the content_type when the filename has .xls

Thanks!

@javan I noticed https://contributors.rubyonrails.org wrongly credited this commit to the branch name because it was in square brackets in the commit. Very much not important, but wondering if there's a way to manually overwrite? Thanks

Wups! Opened rails/rails-contributors#146 to fix that up.

All better now: https://contributors.rubyonrails.org/contributors/nick-weiland/commits

Thanks @javan!

It seems like the npm package (https://www.npmjs.com/package/@rails/activestorage) hasn't reflected the changes in this commit yet. The PR conversation is most likely not the right place to ask, but how can I implement this commit without waiting for the npm package to update?

It seems like the npm package (https://www.npmjs.com/package/@rails/activestorage) hasn't reflected the changes in this commit yet. The PR conversation is most likely not the right place to ask, but how can I implement this commit without waiting for the npm package to update?

@carlaraya I basically forked the Rails repo from the 6.0.2.1 release, cherry-picked the commit that made this fix, then extracted the activestorage subdirectory into another git repo to create a patched activestorage repo, which I could then use directly with yarn, because it supports adding from a git repo, but unfortunately not if the package is in a subdirectory of a repo (see here).

So in my case, adding the patched package with yarn became: yarn add https://github.com/smartygus/activestorage

I just backported this in 2c19a6e so it'll go out in the next release.

Great! Thank you so much!! I was just facing this issue after updating to rails 6.

When is the next update including this fix for the npm package planned to happen? The las update was 5 months ago.

@maurobender the package you linked to is no longer used for Rails 6 (for Rails 5 only it seems). You can find the updated package here: https://www.npmjs.com/package/@rails/activestorage

@maurobender the package you linked to is no longer used for Rails 6 (for Rails 5 only it seems). You can find the updated package here: https://www.npmjs.com/package/@rails/activestorage

Thanks a lot @smartygus! Any chance of adding this to the guides (maybe here)?

Any chance of adding this to the guides (maybe here)?

@maurobender do you mean something to explain that the npm packages have moved? This is mentioned in the guide for upgrading from Rails 5.2 to Rails 6, and I think that's probably the most appropriate place to document such changes: https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#all-npm-packages-have-been-moved-to-the-@rails-scope
As far as I can tell, all mentions of the ActiveStorage npm package in the guides have also been updated to use the @rails/activestorage scoped package name, so I think the guides seem okay in terms of pointing people to the correct package.

Or did you have something else in mind?